Implement the ability to register custom watcher implementations #91
Conversation
This allows registering a special-purpose factory that returns its own `Watcher` implementation that will take precedence over the default ones. The main motivation for this is handling of file systems that need custom code to watch for changes.
michalt
force-pushed
the
custom-watcher-factory
branch
from
b1c8092 to
195a23d
Compare
lib/src/custom_watcher_factory.dart
Outdated
| /// the built-in watchers. | ||
| /// | ||
| /// Note that we will try [CustomWatcherFactory] one by one in the order they | ||
| /// were registered. |
There was a problem hiding this comment.
I'm nervous that this could end up with different behaviour based on startup order ... some ideas for making it stable:
- Check by name order instead of register order :)
- Or, always check all of them, and fail if multiple watchers claim the same path
WDYT?
There was a problem hiding this comment.
Yeah, all the options have some downsides, but perhaps the one that throws is better, since we can provide a clear error and so any debugging should be easier.
|
Thanks! (I had to make another change to one of the tests to make it work across platforms, hopefully this time it'll work better ;) |
|
I've got some changes I'd like to make to the design here. Is there a doc or prototype CL you have started for using this? I'd like to understand why you need the capability to unregister a custom watcher. |
|
One other thing to note, anytime we modify a package that isn't already at a https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change |
|
@natebosch Thanks for taking a look! I don't strictly need the ability to unregister a watcher, so I'd be ok with removing it if that's what you prefer. |
…actory Implement the ability to register custom watcher implementations
Currently to handle special file systems, we need to internally patch the package to create specialized
Watchers. This change allows to dynamically register aWatcherfactory that will take precedence over the default options. The applications could then "register" such factories as needed.CC @davidmorgan